Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add api to create onboarding extension request from discord server #2307

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

pankajjs
Copy link
Contributor

@pankajjs pankajjs commented Dec 19, 2024

Date: 20 Dec, 2024

Developer Name: @pankajjs


Issue Ticket Number

Description

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Working Videos
output_time_0.mp4
output_time_1.mp4
d2.mp4
d4.mp4
d5.mp4

Test Coverage

Test Coverage has been added in test PR #2306.

Additional Notes

The test PR #2306 has to be merged to this PR and then this PR can be merged in develop.
Design doc
PRD

@pankajjs pankajjs force-pushed the feat/add-onboarding-extension-request-api branch 5 times, most recently from efaf13f to b9145af Compare December 27, 2024 18:12
@pankajjs pankajjs marked this pull request as ready for review December 28, 2024 10:26
@vikasosmium vikasosmium self-requested a review December 28, 2024 12:37
@pankajjs pankajjs force-pushed the feat/add-onboarding-extension-request-api branch from 24310e2 to eca0c3a Compare December 29, 2024 05:39
const { data: userStatus } = await getUserStatus(userId);

if(!userStatus || userStatus.currentStatus.state != userState.ONBOARDING){
return res.boom.unauthorized(UNAUTHORIZED_TO_CREATE_ONBOARDING_EXTENSION_REQUEST);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check if this is correct response we want to send

@Achintya-Chatterjee Achintya-Chatterjee changed the title Add api to create onboarding extension request from discord server feat: Add api to create onboarding extension request from discord server Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Extend Onboarding Override for Discord Server
2 participants